Use arm runners #622
Merged
Use arm runners #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs some more work. While this speeds up uncached builds so they only take 20 minutes instead of 2-3 hours, for cached builds there is very little difference in build time. That little difference in build time is however 7-14x more expensive because the builds are using non-free runners. |
|
This pull request is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed. |
|
This pull request is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed. |
leighmcculloch
force-pushed
the
use-arm-runners
branch
from
01649a0
to
1028b76
Compare
graydon
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use arm64 runners to build core, rpc, and xdr-cli.
Uses free amd64 instances to first attempt to recover previously build core, rpc, and xdr-cli binaries from the GitHub Action cache.
Horizon, friendbot, and the quickstart image itself are still built only with free amd64 runners, because there doesn't appear to be a significant need to optimise those which would add additional cost.
Why
More efficient arm builds without needing emulation.
Lately core, now that it has all the rust components to build, has been taking a long time and struggling in many instances to build successfully. This changes brings core build time down to a consistent 20mins on the 4-core arm64 instance.
The workflow has many individual steps because building a single dependency like core first spins up a free amd64 instance to check the cache and load the image from there, and then the more expensive arm64 instance is only triggered when we actually need to build.
Trying It Out