Add --enable-soroban-diagnostic-events flag
#435
Conversation
|
@paulbellamy , is there a specific issue/ticket related to this task? Wanted to check on context, thanks. |
|
Not directly. We were originally going to do #434, but decided that (because normal events are not logged) diagnostic events should not be logged. We still need a way to enable it for quickstart, though, so added this flag instead. |
|
I saw the soroban tests failing, the core git ref for soroban needs to be bumped in any case related to soroban release prep, so, should be ok if we do that here, added a commit - 6c9a2e1 |
|
friendbot tx subs are failing when soroban core is enabled, running the newer core version there, gonna try this out locally and see what's up |
…cache key based on source branch ref was not invalidating the horizon/friendbot build image cache key when branch had new commits
…hat to latest yet, go:soroban-xdr-next doesn't have that latest xdr yet
…t bump that to latest yet, go:soroban-xdr-next doesn't have that latest xdr yet" This reverts commit 1d008c1.
|
Depends on stellar/stellar-cli#536, to update the |
… builds on commit changes for branch refs
Part of stellar/stellar-cli#471
Add a new quickstart flag to enable diagnostic events.
Closes #436 and #474
Note: This will need core upgraded in order to do anything.
An alternative to an explicit flag would be to just always enable diagnostic events for non-futurenet deployments.