Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Soroban RPC packaging #183

Merged
merged 7 commits into from
Nov 9, 2022
Merged

Add Soroban RPC packaging #183

merged 7 commits into from
Nov 9, 2022

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Nov 2, 2022 •
edited
Loading

Create debian package of the Soroban RPC executable

Closes stellar/go#4655

depended by: https://github.com/stellar/pipelines/pull/470

@sreuland sreuland requested a review from a team November 2, 2022 22:23
jacekn
jacekn reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@jacekn jacekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks really good. I added a few very small comments, hopefully will be trivial to address

stellar-soroban-rpc/debian/stellar-soroban-rpc.default Outdated Show resolved Hide resolved
stellar-soroban-rpc/debian/stellar-soroban-rpc.postinst Outdated Show resolved Hide resolved
satyamz
satyamz approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@satyamz satyamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jacekn
jacekn approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@jacekn jacekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing feedback!

@sreuland sreuland mentioned this pull request Nov 7, 2022
Closed
@sreuland sreuland merged commit bca35d9 into master Nov 9, 2022
@tsachiherman tsachiherman mentioned this pull request Feb 1, 2024
Closed
38 tasks
@mollykarcher mollykarcher mentioned this pull request Mar 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacekn jacekn jacekn approved these changes

@satyamz satyamz satyamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exp/services/rpc-soroban: packaging and releases
3 participants
@sreuland @satyamz @jacekn