Update README replacing ed25519 with sodium-native per upstream
#536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#534 - Remove section of README discussing fixes for Win ed25519 install that no longer apply. - Change "Warning" to "Important". There is no danger in use of `tweetnacl` and no need to be alarmist. - Remove unsubstantiated speed language. This is not a concern for most as `tweetnacl` can perform at least 200 signing ops/s and negative comparisons are not backed by data. Comparison might also have been against `ed25519` lib.
|
@grempe btw, could you turn on commit signing ? we try to use it as much as possible in our repos. This is a good guide on how to do it with KeyBase https://github.com/pstadler/keybase-gpg-github |
|
Thanks @abuiles Yes, I normally use commit signing. I happened to use 'gitup' GUI this time to commit in the interests of speed and it didn't do the sig. Of course this is the first time in years of signing commits that someone called me out for not doing so. lol 🥇 Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#534
tweetnacland no need to be alarmist.tweetnaclcan perform at least 200 signing ops/s and negative comparisons are not backed by data. Comparison might also have been againsted25519lib.