Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for a global EventSource before deciding what to use. #389

Merged
merged 2 commits into from
Jul 26, 2019

Conversation

fnando
Copy link
Member

@fnando fnando commented Jul 26, 2019

This approach gives you the flexibility to inject polyfills in other environments like react-native.

This approach gives you the flexibility to inject polyfills in other environments like react-native.
@@ -149,7 +151,10 @@ export class CallBuilder<
createEventSource();
return function close() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed before that this function keeps trying to write to es even if the assignment fails. I feel like it should return in the catch rather than continuing with the function. Can you make that fix too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely! :)

@abuiles abuiles merged commit 1e0ab11 into master Jul 26, 2019
@abuiles abuiles deleted the global-eventsource branch July 26, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants