Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cachebust query instead of adding #170

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Conversation

vcarl
Copy link
Contributor

@vcarl vcarl commented May 30, 2018

Resolve #169

@bartekn
Copy link
Contributor

bartekn commented May 30, 2018

This looks good, but let me check if we still need to send random value with each request. This shouldn't be required if Horizon was sending cache-related headers.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.103% when pulling 64fa458 on vcarl:replace-c into 30f8be6 on stellar:master.

@ire-and-curses
Copy link
Member

Stack Overflow suggests Cache-Control: no-store could resolve this without need for random strings at all (multiple confirming comments at https://stackoverflow.com/a/27514611/143804).

Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We will eventually remove this as stellar/go#476 is a proper solution.

@bartekn bartekn merged commit 3a70aed into stellar:master Jun 4, 2018
@vcarl vcarl deleted the replace-c branch June 4, 2018 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants