Update asset sorting method to match other sdk's #605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I update the asciicompare function to properly sort upper case letters before lower case regardless of their position of the alphabet.
each is a string not a number, but we need a number to properly compare the length so we set a variable called letter pos using parseInt(each)
|
Thanks so much for the PR, this is great. I pulled it into #606, and did a bit of refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix #593
I update the asciicompare function to properly sort upper case letters before lower case regardless of their position of the alphabet.
We should probably add some better fuzz tests also. Also someone else should review + test this before merging it as I only spent a short time on it.
Thanks!