Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding builder methods for new preconditions. #512

Closed
wants to merge 0 commits into from
Closed

Conversation

paulbellamy
Copy link
Contributor

Fixes #508

Note: this is pending on xdr updates to add the new fields to the txn envelope. I've made a guess at their location, but the txn constructor might need updating.

@paulbellamy paulbellamy requested a review from Shaptic April 1, 2022 16:00
@paulbellamy
Copy link
Contributor Author

Should setMinTime/setmaxTime, take epoch milliseconds instead of epoch seconds? It would make Date.now(), and new Date().valueOf() type stuff more intuitive in js. But we'd be throwing away some precision. Is there a good example somewhere else we could follow for consistency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support add'l preconditions (CAP-21) when building transactions
1 participant