Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CAP-35 support to the SDK. #397

Merged
merged 18 commits into from
Mar 25, 2021
Merged

Add CAP-35 support to the SDK. #397

merged 18 commits into from
Mar 25, 2021

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Mar 20, 2021

Fulfills creation the list of CAP-35 features:

New operations

  • clawback with the following fields:

    • Asset fields (identical to the asset fields in the Change Trust, Allow Trust and Set Trustline Flags operations)
      • asset_type
      • asset_code
      • asset_issuer
    • from - account from which the asset is clawed back
    • amount - asset amount clawed back
  • clawback_claimable_balance, with the following field:

    • balance_id - claimable balance identifer of the claimable balance to be clawed back
  • set_trust_line_flags, with the following fields:

    • Asset fields (identical to the asset fields in the Change Trust, Allow Trust and Set Trustline Flags operations)
      • asset_type
      • asset_code
      • asset_issuer
    • trustor - account whose trustline is affected by this operation
    • flag fields, with the same scheme as the Set Options operation (note that CAP-35 introduces the new AUTH_CLAWBACK_ENABLED_FLAG flag)

Related to #395.

@Shaptic Shaptic requested a review from a team March 20, 2021 00:53
@Shaptic Shaptic self-assigned this Mar 20, 2021
src/operations/clawback.js Outdated Show resolved Hide resolved
src/operations/set_trustline_flags.js Outdated Show resolved Hide resolved
test/unit/operation_test.js Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/operations/set_trustline_flags.js Outdated Show resolved Hide resolved
@Shaptic Shaptic changed the title Adds most of the CAP-35 features to the SDK. Add CAP-35 support to the SDK. Mar 23, 2021
Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a small suggestion below but other than that it looks great to me!

test/unit/operation_test.js Show resolved Hide resolved
@Shaptic Shaptic merged commit a3f61a3 into master Mar 25, 2021
@Shaptic Shaptic deleted the cap35 branch March 25, 2021 16:01
@Shaptic Shaptic mentioned this pull request May 3, 2021
5 tasks
Shaptic added a commit that referenced this pull request Aug 3, 2021
New Operations:

  * clawback with the following fields:
    - asset
    - from - account from which the asset is clawed back
    - amount - asset amount clawed back

  * clawback_claimable_balance, with the following field:
    - balance_id - claimable balance identifer of the claimable balance 
      to be clawed back

  * set_trust_line_flags, with the following fields:
    - asset
    - trustor - account whose trustline is affected by this operation
    - flag fields, with the same scheme as the Set Options operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants