Add toString() to Asset
#172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
suggested changes
Jul 17, 2019
There was a problem hiding this comment.
@charlie-wasp thanks for this PR! I agree the proposed format makes more sense than [object Object] :)
Could you rebase off master and cleanup asset_test.js to include only your change and no the formatting changes?
|
@abuiles thank you, I'm on it! |
charlie-wasp
force-pushed
the
feature/asset-to-string
branch
2 times, most recently
from
9c00d51
to
c438985
Compare
|
@abuiles done ✅ |
abuiles
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
@charlie-wasp thanks! LGTM.
@bartekn @morleyzhi do you have any thoughts about this? otherwise, I think we should merge.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! 👋
What about overriding
Asset.toString()method? I believe it would be useful to return something more meaningful from that. I ended up withcode-issuerformat and justnativefor lumens.What do you think?
P.S. Sorry for the formating mess in a diff, it's prettier in the pre-commit hook 😕