Handle null ledger entries and return a better error for missing accounts #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
approved these changes
Jul 17, 2023
| @@ -34,7 +34,7 @@ export namespace SorobanRpc { | |||
| /* Response for jsonrpc method `getLedgerEntries` | |||
| */ | |||
| export interface GetLedgerEntriesResponse { | |||
| entries: LedgerEntryResult[]; | |||
| entries: LedgerEntryResult[] | null; | |||
There was a problem hiding this comment.
why couldn't it just be empty instead of null 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the js client version of stellar/stellar-cli#771
If the soroban-rpc server finds no matching entries for a
getLedgerEntries, it will returnentries: null. The client should handle this.Also, if we try to do a
getAccountand don't find it, we can return a more helpful error to the user.