Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js-soroban-client: add support for fees #76

Closed
tsachiherman opened this issue May 3, 2023 · 6 comments · Fixed by #77
Closed

js-soroban-client: add support for fees #76

tsachiherman opened this issue May 3, 2023 · 6 comments · Fixed by #77
Assignees
@sreuland
Labels
preview-9 soroban-scrum

Comments

@tsachiherman
Copy link
Contributor

What ?

txnbuilder and prepareTransaction need changes to support the fee model, because they need to set which resources the txn will use

Epic

stellar/stellar-cli#519
@tsachiherman tsachiherman moved this from Backlog to In Progress in Platform Scrum May 3, 2023
@tsachiherman tsachiherman moved this from In Progress to Current Sprint in Platform Scrum May 3, 2023
@tsachiherman tsachiherman mentioned this issue May 3, 2023
Closed
@sreuland sreuland self-assigned this May 5, 2023
@sreuland sreuland moved this from Current Sprint to In Progress in Platform Scrum May 5, 2023
@sreuland
Copy link
Contributor

sreuland commented May 5, 2023

@tsachiherman , is there an example in go or any other sdk's of how a client is expected to set resources/fees when building an invokehostfn txn? Or a link to docs/cap with some details on the expectations, thanks!

@sreuland
Copy link
Contributor

sreuland commented May 8, 2023

@tsachiherman , is there an example in go or any other sdk's of how a client is expected to set resources/fees when building an invokehostfn txn? Or a link to docs/cap with some details on the expectations, thanks!

thanks for discussion, am able to proceed on related changes in sdk. most of the changes for handling the new simulation response with SorbanTransactionData will be in the assembleTransaction method.

@sreuland
Copy link
Contributor

sreuland commented May 9, 2023 •
edited
Loading

this depends on latest xdr updates from js-stellar-base, will use the new v9.0.0-soroban.1 - stellar/js-stellar-base#602 and the rpc simulation endpoint enhancement for fees - https://github.com/stellar/soroban-tools/pull/636/files

sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 9, 2023
@sreuland
stellar#76: use newer rpc simulation results on transaction prepare, …
79eff07 
…apply new minium suggested fee
@sreuland sreuland mentioned this issue May 9, 2023
Merged
sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 11, 2023
@sreuland
stellar#76: added test coverage on invokehostfn simulation
d15d753
sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 11, 2023
@sreuland
stellar#76: added suggestedInclusionFee from rpc siulation response, …
4384b3f 
…update the tx fee
@sreuland
Copy link
Contributor

PR - #77

sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 11, 2023
@sreuland
stellar#76: use better approach to iterate list of auths from pr feed…
ec786ab 
…back
@sreuland sreuland moved this from In Progress to Blocked in Platform Scrum May 11, 2023
@sreuland
Copy link
Contributor

moving this to blocked as dev and unit test complete, but tests are failing due a strange issue with the js xdr generation, investigating further on pr - #77 (comment)

sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 11, 2023
@sreuland
stellar#76: retain cost object on simulation response
875717a
sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 14, 2023
@sreuland
stellar#76: use workaround on ts construcxtor for TransactionExt
e62832c
sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 14, 2023
@sreuland
stellar#76: updated TODO content
77c81d5
@sreuland
Copy link
Contributor

found a workaround and moved pr back to review - #77

@sreuland sreuland moved this from Blocked to Needs Review in Platform Scrum May 14, 2023
sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 15, 2023
@sreuland
stellar#76: updated server docs, removed suggestedInclusionFee per re…
de9a9df 
…view clarification
sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 15, 2023
@sreuland
stellar#76: working on ci yarn pkg failures
4c98212
sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 15, 2023
@sreuland
stellar#76: fixed ci browser unit test
e130f98
sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 15, 2023
@sreuland
stellar#76: fixed tx fee update logic for min resource fees
a853363
sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 15, 2023
@sreuland
stellar#76: adding more context on prepareTransaction js docs for fee…
3e9f2d0 
…s behavior
sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 16, 2023
@sreuland
stellar#76: use txBuilder.setSorobanData
6b2c183
sreuland added a commit to sreuland/js-soroban-client that referenced this issue May 16, 2023
@sreuland
stellar#76: use rel version of stellar-base
18314ef
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum May 18, 2023
@Shaptic Shaptic mentioned this issue May 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreuland sreuland

Labels
preview-9 soroban-scrum
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the new Soroban RPC simulation method when preparing transactions sreuland/js-soroban-client
3 participants
@mollykarcher @sreuland @tsachiherman