Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add unit test for new --ledgerbackend flag #5382

Merged

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Jul 9, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Add unit test for new --ledgerbackend flag

Why

#4911

Known limitations

N/A

@urvisavla urvisavla changed the title 4911/reingest txmeta services/horizon: Add unit test for new --ledgerbackend flag Jul 9, 2024
@urvisavla urvisavla force-pushed the 4911/reingest_txmeta branch 2 times, most recently from 533fe37 to 3eaa41f Compare July 10, 2024 17:03
@urvisavla urvisavla force-pushed the 4911/reingest_txmeta branch from 3eaa41f to 4908a1d Compare July 10, 2024 17:07
@urvisavla urvisavla marked this pull request as ready for review July 10, 2024 17:34
@urvisavla urvisavla requested a review from sreuland July 10, 2024 17:39
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment for consideration, adding more test cases.

@urvisavla urvisavla merged commit 7234d6e into stellar:reingest_precomputed Jul 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants