-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exp/services/ledgerexporter: create go integration tests for sub commands #5370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nds, standalone network, fake gcs
urvisavla
reviewed
Jul 3, 2024
urvisavla
reviewed
Jul 3, 2024
urvisavla
reviewed
Jul 3, 2024
urvisavla
reviewed
Jul 3, 2024
urvisavla
reviewed
Jul 3, 2024
urvisavla
reviewed
Jul 3, 2024
urvisavla
reviewed
Jul 3, 2024
urvisavla
reviewed
Jul 3, 2024
…e path, make cli commands be instance not package static vars
…ntegration test to not bind to peer port
…tandalone instance
…ded(for test purposes) soroban upgrades to local network
urvisavla
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Added new go integration tests that verify ledger exporter 'scan-and-fill' and 'append' commands.
support/datastore
to verify exported files exist on gcs.Why
refactor from docker based testing infrastructure, follow standard convention in mono-repo of integration tests being next to unit tests, but enabled with env variable.
Closes https://stellarorg.atlassian.net/browse/HUBBLE-469
Known limitations
not fully parallelizable yet, some measure were taken for dynamic port usage of fake gcs server.