exp/tools/dump-ledger-state: Remove dump-ledger-state script #5363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Remove dump-ledger-state script and the CI job which publishes the stellar/ledger-state-diff docker container.
Why
The dump-ledger-state script relies on being able to query ledger entries from the stellar-core SQL db. However, stellar-core will no longer store ledger entries in its SQL db. Instead, stellar-core will maintain ledger entries in the bucketlistdb. The functionality which is tested in the dump-ledger-state script mostly overlaps with state verification, so it's not really worth updating the script so that it can extract ledger entries from bucketlistdb instead of the stellar-core SQL db.
Known limitations
[N/A]