-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG for Horizon release 2.31.0 #5345
Update CHANGELOG for Horizon release 2.31.0 #5345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I think we should mention in the changelog that EXPERIMENTAL_BUCKETLIST_DB=true must be set in the captive-core config. 89068a9. |
I think this conditional case is still automated in toml.go, i.e. it will add EXPERIMENTAL_BUCKETLIST_DB=true when absent and UseDB = true https://github.com/aditya1702/go/blob/changelog/ingest/ledgerbackend/toml.go#L541 but, I think we should mention the opposite use case when using a custom captive core config and Horizon UseDB=false, user needs to ensure that they remove EXPERIMENTAL_BUCKETLIST_DB from captive core config toml when stellar-core is less than 21.0.0 and if they are using stellar-core 21.0.0. or up, then should add:
Once #5333 merges, then that simplifies this, removes the need to do |
Co-authored-by: shawn <[email protected]>
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Update Changelog for the release.
Why
N/A
Known limitations
N/A