Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/ledgerexporter: Move ledgerexporter out of experimental #5341

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Jun 12, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

  1. Move ledgerexporter from the experimental directory to the main services directory.
  2. Rename Ledgerexporter to Galexie.

Why

https://stellarorg.atlassian.net/browse/HUBBLE-456

Known limitations

We will need to rename the Docker repository created for ledgerexporter and update the metrics dashboard with the new prefix.

@urvisavla urvisavla added the WIP label Jun 12, 2024
@urvisavla urvisavla force-pushed the HUBBLE-456/move-lexie-out-of-exp branch from d2006fb to 13c6794 Compare June 12, 2024 19:58
@urvisavla urvisavla force-pushed the HUBBLE-456/move-lexie-out-of-exp branch 3 times, most recently from faab97c to 124b8bc Compare July 16, 2024 22:04
@urvisavla urvisavla marked this pull request as ready for review July 17, 2024 17:32
@urvisavla urvisavla requested review from a team and jacekn July 17, 2024 19:17
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, after seeing the move/rename pattern, I skimmed through remainder, doesn't look like any new funcationality. good call-out on the need for docker repo rename as well.

@urvisavla urvisavla force-pushed the HUBBLE-456/move-lexie-out-of-exp branch from 124b8bc to 949c907 Compare July 18, 2024 16:42
@urvisavla urvisavla requested a review from tamirms July 18, 2024 16:44
@urvisavla urvisavla merged commit a3fae02 into stellar:master Jul 19, 2024
23 checks passed
@urvisavla urvisavla deleted the HUBBLE-456/move-lexie-out-of-exp branch July 19, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants