Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingestion filtering should use OR logic for rules rather than AND #5303

Merged
merged 13 commits into from
May 10, 2024

Conversation

aditya1702
Copy link
Contributor

@aditya1702 aditya1702 commented May 7, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

#5304

Why

We want transactions to be stored if it matches atleast one of the ingestion filtering rules.

Known limitations

[TODO or N/A]

@aditya1702 aditya1702 linked an issue May 7, 2024 that may be closed by this pull request
@aditya1702 aditya1702 self-assigned this May 7, 2024
@aditya1702 aditya1702 marked this pull request as ready for review May 7, 2024 20:28
@Shaptic Shaptic requested a review from 2opremio May 7, 2024 20:33
@aditya1702 aditya1702 requested a review from sreuland May 10, 2024 17:27
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. left some comments on additional test coverage for consideration.

wanted to also suggest for consideration, would be worthwhile to add a changelog entry under Unreleased for this so that you can provide a more detailed description for it, as this is changing the inclusion behavior of filters and so, can highlight this as a 'breaking' change under Unreleased, otherwise the next release process would probably not pick up on this meaning, and it would just be added under general changes with the pr title.

@aditya1702 aditya1702 enabled auto-merge (squash) May 10, 2024 19:40
@aditya1702 aditya1702 merged commit 0f6abb0 into stellar:master May 10, 2024
31 checks passed
@aditya1702 aditya1702 deleted the ingestion-filtering-bug branch May 13, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingestion filtering should take an OR of all filtering rules
3 participants