refresh quorum config based off https://www.stellarbeat.io/ #5276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi, @stellar/platform-committers |
mollykarcher
approved these changes
Apr 15, 2024
Shaptic
requested changes
Apr 15, 2024
There was a problem hiding this comment.
How sure are we about these? The diff is super hard to read and we should be extra careful here. For example, and maybe I'm reading it wrong, but it seems like the lobstr 2 (Europe) validator key changed:
-NAME="lobstr_2_europe"
-PUBLIC_KEY="GDXQB3OMMQ6MGG43PWFBZWBFKBBDUZIVSUDAZZTRAWQZKES2CDSE5HKJ"
+NAME="LOBSTR 2 (Europe)"
+PUBLIC_KEY="GCB2VSADESRV2DDTIVTFLBDI562K6KE3KMKILBHUHUWFXCUBHGQDI7VL"It'd be nice if there was a cleaner diff showing what changed closer to its original line, or if there was another way we can see what the exact changes are between the two configs.
|
There was a lot of drift over the years: Lobstr EU's key was changed about
10 months ago.
Config can be verified against stellarbeat (we use the same config
internally too)
…On Mon, Apr 15, 2024 at 3:57 PM George ***@***.***> wrote:
***@***.**** requested changes on this pull request.
How sure are we about these? The diff is super hard to read.
This is a pretty nasty attack vector, right? So let's be extra careful
here. For example, the LOBSTR 2 (Europe) validator key seems to have
changed:
-NAME="lobstr_2_europe"-PUBLIC_KEY="GDXQB3OMMQ6MGG43PWFBZWBFKBBDUZIVSUDAZZTRAWQZKES2CDSE5HKJ"+NAME="LOBSTR 2 (Europe)"+PUBLIC_KEY="GCB2VSADESRV2DDTIVTFLBDI562K6KE3KMKILBHUHUWFXCUBHGQDI7VL"
—
Reply to this email directly, view it on GitHub
<#5276 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAEYA6GEV2NZ32ILASOFBDY5RLOJAVCNFSM6AAAAABGF34WTSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMBSGMYDQNRYGI>
.
You are receiving this because you are on a team that was mentioned.Message
ID: ***@***.***>
|
Indeed to both of these. I was equally annoyed by this when making these changes in other places. See the description on this PR for a couple suggestions on how to make it slightly less painful. |
Shaptic
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.