Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest: reduce memory consumption of CheckpointChangeReader #5270

Merged
merged 9 commits into from
Apr 15, 2024

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Mar 31, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Reduce memory consumption by about 1GB when iterating through ledger entries during state verification and state rebuilds. This reduction in memory is achieved by:

  1. Removing claimable balance and offer ledger keys from the visited set when encountering the init entry.
  2. Using map[string]struct{} to store ledger keys instead of map[string]bool{} (see https://stackoverflow.com/questions/57620170/can-you-have-a-map-with-no-value-in-go )

The first optimization takes advantage of the fact that claimable balance and offer ids are globally unique. Once a claimable balance or offer is deleted it is impossible to restore it or create a new claimable balance / offer with the same id.

Known limitations

[N/A]

@tamirms tamirms force-pushed the improve-checkpoint-change-reader branch from 2c73cf6 to ba2a0bc Compare April 1, 2024 11:14
@tamirms tamirms marked this pull request as ready for review April 15, 2024 14:15
@tamirms tamirms requested a review from a team April 15, 2024 14:31
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left comment for consideration in adding test coverage if possible

ingest/memory_temp_set.go Outdated Show resolved Hide resolved
@tamirms tamirms enabled auto-merge (squash) April 15, 2024 22:22
@tamirms tamirms merged commit f908a42 into stellar:master Apr 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants