services/horizon/internal/ingest/processors: Fix bug in claimable balance change processor #5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests for claimable balanace update case
leighmcculloch
approved these changes
Mar 14, 2024
urvisavla
reviewed
Mar 14, 2024
| @@ -112,6 +117,12 @@ func (p *ClaimableBalancesChangeProcessor) Commit(ctx context.Context) error { | |||
| return errors.Wrap(err, "error executing ClaimableBalanceBatchInsertBuilder") | |||
| } | |||
|
|
|||
| if len(updatedBalances) > 0 { | |||
| if err = p.qClaimableBalances.UpsertClaimableBalances(ctx, updatedBalances); err != nil { | |||
There was a problem hiding this comment.
Do we also need to restore the BatchInsertBuilder to handle upserts for claimants? Like what happens if new claimants are added? Will we skip adding those to the claimants table?
There was a problem hiding this comment.
UpsertClaimableBalances() will upsert to both the claimable_balances and the claimable_balance_claimants tables
There was a problem hiding this comment.
Oh, it seemed to me that UpsertClaimableBalances exclusively inserts to claimable_balances table
There was a problem hiding this comment.
I updated the function in a later commit:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
In #5086 we made some optimizations to the claimable change processor based on the assumption that claimable balances are always created or removed but never updated. It turns out that assumption is incorrect because it's possible for the sponsor of a claimable balance to change. This commit corrects that assumption and allows the change processor to ingest updated claimable balance ledger entries.
Known limitations
[N/A]