Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/ingest/processors: Fix bug in claimable balance change processor #5246

Merged
merged 7 commits into from
Mar 14, 2024

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Mar 14, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

In #5086 we made some optimizations to the claimable change processor based on the assumption that claimable balances are always created or removed but never updated. It turns out that assumption is incorrect because it's possible for the sponsor of a claimable balance to change. This commit corrects that assumption and allows the change processor to ingest updated claimable balance ledger entries.

Known limitations

[N/A]

@tamirms tamirms requested a review from a team March 14, 2024 09:04
@@ -112,6 +117,12 @@ func (p *ClaimableBalancesChangeProcessor) Commit(ctx context.Context) error {
return errors.Wrap(err, "error executing ClaimableBalanceBatchInsertBuilder")
}

if len(updatedBalances) > 0 {
if err = p.qClaimableBalances.UpsertClaimableBalances(ctx, updatedBalances); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to restore the BatchInsertBuilder to handle upserts for claimants? Like what happens if new claimants are added? Will we skip adding those to the claimants table?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UpsertClaimableBalances() will upsert to both the claimable_balances and the claimable_balance_claimants tables

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it seemed to me that UpsertClaimableBalances exclusively inserts to claimable_balances table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the function in a later commit:

672d637

@tamirms tamirms changed the base branch from master to release-horizon-v2.29.0 March 14, 2024 09:41
@tamirms tamirms merged commit 71fef3c into stellar:release-horizon-v2.29.0 Mar 14, 2024
29 checks passed
@tamirms tamirms deleted the cb-processor-fix branch March 14, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants