Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 2.28.1 back to mainline #5195

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Feb 5, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

port hot fix from horizon 2.28.1 back to mainline

Why

keep mainline in sync with latest releases

Known limitations

aditya1702 and others added 3 commits February 5, 2024 08:27
* Add check for ledger state in txsub

* Add test for badSeq

* Fix failing unittest

* Update system_test.go

* Small changes

* Update main.go
@sreuland sreuland requested a review from a team February 5, 2024 16:35
@sreuland sreuland merged commit 4a57a2a into stellar:master Feb 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants