clients/stellarcore horizon: Obtain and expose diagnostic events in transaction endpoint #5148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransaction endpoint
sreuland
reviewed
Dec 22, 2023
sreuland
reviewed
Dec 22, 2023
Shaptic
reviewed
Dec 22, 2023
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When submitting failing soroban transactions, Core may return a new
"diagnostic_events"field with which to debug what happened.This PR exposes the new field in the Core client. Also, it adds a new extra
"diagnostic_events"field in Horizon's transaction submission endpoint.Why
Improve debugability of failing soroban transactions. Also, it paves to way for exposing diagnostic events in soroban-RPC's
sendTransactionendpoint.Known limitations
Core currently only supports this on nodes with diagnostic events explicitly enabled. @dmkozh is working on enabling the
"diagnostic_events"field unconditionally.