Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/docker/verify-range: Fix comparison of claimable balance ids in verify-range script #5147

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Dec 21, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This commit contains two fixes for the verify-range script:

  1. The verify range script should compare hex claimable balance ids instead of internal history claimable balance integer ids.
  2. The verify range script does not check the history_operation_liquidity_pools and history_transaction_liquidity_pools tables.

The reason for (1) is because the generation of integer history ids can vary between implementations. For example, in horizon 2.28.0 we generate the history ids for all claimable balances in all the transactions of the ledger. Whereas in previous horizon releases we generate the history ids for claimable balances when ingesting each transaction. The differences in this behavior can lead to different history ids being assigned to the same set of claimable balances.

Known limitations

[N/A]

@tamirms tamirms requested a review from sreuland December 21, 2023 11:22
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for fix!

@tamirms tamirms merged commit cf708f8 into stellar:master Dec 21, 2023
28 checks passed
@tamirms tamirms deleted the fix-verify-range-script branch December 21, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants