Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: cleanup process runner tests #5114

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Nov 15, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Remove unnecessary code from process_runner_tests.go and other formatting changes.

Why

cleanup

Known limitations

N/A

@urvisavla urvisavla changed the title services/horizon: Remove unused mocks and other cosmetic changes services/horizon: cleanup process runner tests Nov 15, 2023
@urvisavla urvisavla requested a review from tamirms November 15, 2023 05:46
@urvisavla urvisavla marked this pull request as ready for review November 15, 2023 05:46
@urvisavla urvisavla merged commit 6cdae54 into stellar:master Nov 16, 2023
26 checks passed
@urvisavla urvisavla deleted the 5098/fix-process-runner-tests branch November 16, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants