Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Use COPY for inserting into offers table #5111

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Nov 14, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Optimize the OffersChangeProcessor to use FastBatchInsertBuilder which uses COPY to bulk insert into the database table offers. Database update and removal operations remain unchanged.

Why

#5098

Known limitations

[N/A]

@urvisavla urvisavla force-pushed the 5098/offers-processor branch 2 times, most recently from 6a5491e to 12f577c Compare November 14, 2023 07:49
@urvisavla urvisavla marked this pull request as ready for review November 14, 2023 09:14
@urvisavla urvisavla changed the title services/horizon: Use FastBatchInsertBuilder(COPY) for inserting into offers table services/horizon: Use COPY for inserting into offers table Nov 14, 2023
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@urvisavla urvisavla force-pushed the 5098/offers-processor branch from 12f577c to 69bc581 Compare November 14, 2023 20:32
@urvisavla urvisavla merged commit 4bd1d00 into stellar:master Nov 14, 2023
26 checks passed
@urvisavla urvisavla deleted the 5098/offers-processor branch November 14, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants