services/horizon: Suppress stellar-core unreachable error when horizon is building state #5108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Added checks for to avoid logging "could not load stellar-core info" errors when Horizon is in the build state
Why
When we fixed issue #4446, we missed another place where we are attempting to get core info and the same condition is applied i.e. if core is blocked, we log an error. This error is confusing for users (from discord) because it leads them to think that they needed to explicitly run core process, but that is not the case.
Known limitations
As in #4860, we skip querying core so even if core is reachable, we will not update core info. Alternative would be to only perform the checks if there is an error and decide whether to suppress the error or not.