Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Suppress stellar-core unreachable error when horizon is building state #5108

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Nov 10, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Added checks for to avoid logging "could not load stellar-core info" errors when Horizon is in the build state

Why

When we fixed issue #4446, we missed another place where we are attempting to get core info and the same condition is applied i.e. if core is blocked, we log an error. This error is confusing for users (from discord) because it leads them to think that they needed to explicitly run core process, but that is not the case.

Known limitations

As in #4860, we skip querying core so even if core is reachable, we will not update core info. Alternative would be to only perform the checks if there is an error and decide whether to suppress the error or not.

@urvisavla urvisavla force-pushed the suppress-core-unreachable-error branch from fe2fc2e to 191ad53 Compare November 11, 2023 01:48
@urvisavla urvisavla merged commit 7d248ce into stellar:master Nov 13, 2023
26 checks passed
@urvisavla urvisavla deleted the suppress-core-unreachable-error branch November 13, 2023 06:22
@urvisavla urvisavla self-assigned this Nov 13, 2023
@urvisavla urvisavla added the bug label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants