Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code related to legacy ingestion support #5100

Merged
merged 20 commits into from
Nov 7, 2023

Conversation

aditya1702
Copy link
Contributor

@aditya1702 aditya1702 commented Nov 1, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Removes configuration flags (and related tests) supporting legacy ingestion:

  • stellar-core-db-url
  • enable-captive-core-ingestion

Note: The flag definitions are still present and a deprecation warning is added to the command-line.

Why

As part of #4855, we want to remove support for legacy ingestion from Horizon.

Known limitations

N/A

@aditya1702 aditya1702 marked this pull request as ready for review November 3, 2023 16:46
@aditya1702 aditya1702 requested a review from urvisavla November 6, 2023 20:11
@aditya1702 aditya1702 requested a review from sreuland November 6, 2023 22:48
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@aditya1702 aditya1702 merged commit f849153 into stellar:master Nov 7, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants