Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Use COPY to speed up ClaimableBalanceChangeProcessor #5095

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Oct 31, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Use FastBatchInsertBuilder for writing to claimable_balances and claimable_balance_claimants tables. FastBatchInsertBuilder uses ‘COPY' to insert into the db which is faster than using 'INSERT'.

Why

#5086

Known limitations

[TODO or N/A]

@urvisavla urvisavla changed the title 5086/claimable balance fast batch builder services/horizon: Use COPY to speed up ClaimableBalanceChangeProcessor Oct 31, 2023
@urvisavla urvisavla marked this pull request as ready for review October 31, 2023 16:21
@urvisavla urvisavla marked this pull request as draft October 31, 2023 16:29
@urvisavla
Copy link
Contributor Author

As shown in the Ingestion Processor Run Duration graph below, deploying the build with COPY instead of insert to staging significantly reduced the processing time required by the ClaimableBalanceChangeProcessor for the same network activity in claimable balances.

Screenshot 2023-10-24 at 4 10 42 PM

@tamirms tamirms deleted the branch stellar:ingestion-next November 2, 2023 06:30
@tamirms tamirms closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants