Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5061/remove unused indexes #5081

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Oct 12, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Added db migration to remove unused indices from the Horizon database.

Why

see #5061 for details

Known limitations

  • The migration took about 40 mins on staging db which has full history.

  • This migration needs to occur without a transaction. Otherwise, the migration process will maintain an exclusive lock on the tables even after dropping the index, leading to deadlock when concurrent requests that require a shared lock are being served. An alternative approach is to have a separate migration file for each index.

@urvisavla urvisavla marked this pull request as ready for review October 13, 2023 08:38
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@urvisavla urvisavla force-pushed the 5061/remove-unused-indexes branch from 14fdae0 to b977686 Compare October 18, 2023 05:02
@urvisavla urvisavla merged commit 1f0dede into stellar:master Oct 18, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants