Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/docker/verify-range: Update verify-range script #5067

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Sep 25, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

The verify-range job is failing when comparing the latest release (v2.27.0) against the previous one (v2.26.1). The reason for that is because we have added an is_payment column to the history_operations table in the latest release. So when dumping the contents of history_operations there is a mismatch between v2.27.0 and v2.26.1.

@tamirms tamirms requested a review from a team September 25, 2023 16:05
@tamirms tamirms merged commit 7d95f68 into stellar:master Sep 25, 2023
36 checks passed
@tamirms tamirms deleted the verify-range branch September 25, 2023 16:45
2opremio pushed a commit that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants