Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/ingest/processors: Refactor effects processor to support new ingestion data flow #5028

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Aug 28, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Similar to #5025 , this PR refactors the EffectsProcessor so it conforms to the following interface:

type horizonTransactionProcessor interface {
	ProcessTransaction(xdr.LedgerCloseMeta, ingest.LedgerTransaction) error
	Flush(ctx context.Context, session db.SessionInterface) error
}

Why

#4909

Known limitations

Several tests are failing because the ingestion framework still needs to be updated to support the new interface. All those tests will be fixed in an upcoming PR.

@tamirms tamirms requested a review from a team August 28, 2023 11:50
effectType history.EffectType
order uint32
func (p *EffectProcessor) Flush(ctx context.Context, session db.SessionInterface) (err error) {
return p.batch.Exec(ctx, session)
}

// Effects returns the operation effects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, comment could be removed or updated for new method docs.

@tamirms tamirms merged commit 8775648 into stellar:ingestion-next Aug 31, 2023
@tamirms tamirms deleted the ingestion-next branch August 31, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants