Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning and updating golang and ubuntu images #4918

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

mollykarcher
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

  • Upgrade ubuntu versions from 20.04 to 22.04
  • Pin golang images to specify the debian OS version we want to use (bullseye)
  • Sync golang versioning across repos to latest (1.20-bullseye)
  • Run horizon integration tests on the full matrix of ubuntu versions + golang versions which we support

Why

  • See https://stellarfoundation.slack.com/archives/CGY4VS8SZ/p1686928996932389 for more context on pinning the debian OS version in images
  • Ubuntu 22.04 is what we run in production and the latest we support. Note: we should probably include updates in this repo to the process that #ops follows when upgrading to support/deprecate new versions of ubuntu
  • In general, our versioning policy is to support the last 2 releases for libraries, but binaries we want to build/release on the latest versions (ex. test in CI for go 1.19/1.20, but build/release on 1.20)

Known limitations

@mollykarcher mollykarcher marked this pull request as draft June 16, 2023 20:24
@mollykarcher mollykarcher force-pushed the molly/master/versions branch 2 times, most recently from 39d4d77 to 2aa443c Compare June 16, 2023 20:38
@mollykarcher mollykarcher marked this pull request as ready for review June 21, 2023 22:55
@mollykarcher mollykarcher requested a review from a team June 21, 2023 22:56
@mollykarcher mollykarcher changed the title Pinning and updates golang and ubuntu images Pinning and updating golang and ubuntu images Jun 21, 2023
@mollykarcher mollykarcher merged commit 34484c6 into stellar:master Jun 22, 2023
@mollykarcher mollykarcher deleted the molly/master/versions branch June 22, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants