-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xdr: Update XDR to meet core's fees changes #4854
xdr: Update XDR to meet core's fees changes #4854
Conversation
services/horizon/internal/ingest/processors/operations_processor.go
Outdated
Show resolved
Hide resolved
ExtendedMetaDataSizeBytes: 0, | ||
Footprint: xdr.LedgerFootprint{ | ||
ReadOnly: []xdr.LedgerKey{ | ||
// TODO: derive the needed value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsachiherman , I think pr is ready to merge, i had to disable the tests in sac_test.go as they all depended on the preflight http call to core which is gone now, the tests can be re-enabled on later iteration when time to decide how to derive the footprint inline here.
there are working contract tx sub tests in invokehostfunction_test.go which derive the needed footprint for those that can be used as reference, but those are non-sac, so the footprint may not be same approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Unfortunately, since I'm the one who created the PR, I'm unable to approve it.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Update XDR to meet core's fees changes
Why
We need to compile against core.
Known limitations
N/A