Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdr: Update XDR to meet core's fees changes #4854

Merged

Conversation

tsachiherman
Copy link
Contributor

@tsachiherman tsachiherman commented Apr 24, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Update XDR to meet core's fees changes

Why

We need to compile against core.

Known limitations

N/A

@tsachiherman tsachiherman changed the title xdr : update xdr xdr: Update XDR to meet core's fees changes Apr 25, 2023
@tsachiherman tsachiherman self-assigned this Apr 25, 2023
Makefile Outdated Show resolved Hide resolved
@tsachiherman tsachiherman linked an issue May 2, 2023 that may be closed by this pull request
ExtendedMetaDataSizeBytes: 0,
Footprint: xdr.LedgerFootprint{
ReadOnly: []xdr.LedgerKey{
// TODO: derive the needed value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsachiherman , I think pr is ready to merge, i had to disable the tests in sac_test.go as they all depended on the preflight http call to core which is gone now, the tests can be re-enabled on later iteration when time to decide how to derive the footprint inline here.

there are working contract tx sub tests in invokehostfunction_test.go which derive the needed footprint for those that can be used as reference, but those are non-sac, so the footprint may not be same approach.

Copy link
Contributor Author

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Unfortunately, since I'm the one who created the PR, I'm unable to approve it.

@tsachiherman tsachiherman merged commit a6e68f5 into stellar:soroban-xdr-next May 4, 2023
@tsachiherman tsachiherman deleted the tsachi/xdr-update-2 branch May 4, 2023 01:33
@sreuland sreuland requested a review from 2opremio May 4, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(go monorepo) xdr: Update XDR to meet core's fees changes
2 participants