Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/docker: Use latest 1.20 go version when building horizon docker image from source #4836

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Apr 7, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Use latest 1.20 go version when building horizon docker image from source.

Why

The quickstart image uses Dockerfile.dev to build horizon from source so we should be using the latest 1.20 release of Go to build the binary so we can benefit from security fixes

Known limitations

[N/A]

Sorry, something went wrong.

…urce

The quickstart image uses Dockerfile.dev to build horizon from source so we
should be using the latest 1.20 release of Go to build the binary so we
can benefit from security fixes
@tamirms tamirms requested a review from a team April 7, 2023 07:25
@tamirms tamirms merged commit 0b91812 into stellar:master Apr 7, 2023
@tamirms tamirms deleted the dockerfile-go-version branch April 7, 2023 07:31
@sreuland
Copy link
Contributor

sreuland commented Apr 7, 2023

wanted to mention on quickstart dependency, it was modified a little while ago to use it's own Dockerfile.horizon to build horizon, which is using go 1.20 also, so, it's not currently referencing this repo's Dockerfile.dev, maybe we should refactor quickstart back to using this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants