Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add franklin templeton to captive core QS #4786

Merged

Conversation

mollykarcher
Copy link
Contributor

@mollykarcher mollykarcher commented Mar 6, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Add Franklin Templeton to quorum set for captive core nodes. Actual config is managed in puppet and updated here, but we should keep this example in-line as partners often look to it as an example when setting up their config. Additional context in slack.

Why

Known limitations

@mollykarcher mollykarcher force-pushed the molly/main/update-quorum-set branch from dd32f41 to 7335742 Compare March 6, 2023 20:15
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this to the docker configs, as well: https://github.com/stellar/go/tree/master/services/horizon/docker.

@mollykarcher mollykarcher force-pushed the molly/main/update-quorum-set branch from 7335742 to 679c29c Compare March 7, 2023 17:51
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeet it

@mollykarcher mollykarcher merged commit 8e78b57 into stellar:master Mar 9, 2023
@mollykarcher mollykarcher deleted the molly/main/update-quorum-set branch March 9, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants