Enable BucketListDB by default in captive core #4745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sreuland usually we merge master ( eg soroban-xdr-next...master ) into the soroban branch rather than cherry-picking individual commits. |
yes, that's definitely ideal, I wasn't sure on the plan with this branch, i.e. if it will be merged to master for the protocol change. I'll close this pr and spin up a new one for merging latest master back to here, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of a recent change that went in on mainline for enabling bucketlistdb for captive core on-disk mode:
#4733
it could potentially help performance, so wanted to see if we can port this into the soroban branch so that soroban-rpc can reference it?