Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify-range: revert on-disk mode, use S3 URLs for history archives #4697

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Nov 23, 2022

Revert on-disk mode in Captive-Core config and use S3 URLs for history archives. The first change ensures that verify-range container runs fast (currently it takes 2 hours in AWS to ingest state alone for a single range), the second makes the download of bucket files faster in AWS Batch.

@bartekn bartekn requested a review from a team November 23, 2022 15:37
@bartekn bartekn marked this pull request as ready for review November 23, 2022 15:37
@sreuland
Copy link
Contributor

may want to keep an eye on the verify-range ec2's, they should be pretty large compute profile already, just mentioning as will need to have the extra RAM capacity now that core will be using in-mem.

Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bartekn bartekn merged commit 5d6ef22 into stellar:master Nov 24, 2022
@bartekn bartekn deleted the verify-range-memory branch November 24, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants