Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Propogate *all* history archives through the ingestion interface. #4687

Merged
merged 3 commits into from
Nov 17, 2022

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Nov 7, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Use the entire list of provided history archives when ingesting.

Why

Though #3402 allows Captive Core to rotate through a list of history archives, the ingestion interface continued to use the first one in the list. This creates undue strain on certain HA hosts.

Known limitations

n/a

@Shaptic Shaptic requested review from bartekn and a team November 7, 2022 23:59
@Shaptic Shaptic force-pushed the ingest-from-ha-pool branch 4 times, most recently from 128d845 to c0a466e Compare November 8, 2022 00:10
@jcx120 jcx120 added the horizon label Nov 8, 2022
@Shaptic Shaptic force-pushed the ingest-from-ha-pool branch from 6293e5f to 8af1bc4 Compare November 17, 2022 17:14
@Shaptic Shaptic merged commit 0666818 into stellar:master Nov 17, 2022
@Shaptic Shaptic deleted the ingest-from-ha-pool branch November 17, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants