Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add (asset, account_id) index to trust_lines table #4635

Merged
merged 6 commits into from
Oct 12, 2022
Merged

services/horizon: Add (asset, account_id) index to trust_lines table #4635

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1db36de
services/horizon: Add (account_id, asset) index to trust_lines table
bartekn Oct 5, 2022
d82ca74
f=ix
bartekn Oct 5, 2022
2c96a4c
fix
bartekn Oct 5, 2022
5d1bafa
Fix down migraiton
bartekn Oct 5, 2022
77361d4
drop trust_lines_by_type_code_issuer
bartekn Oct 6, 2022
5fe2608
Merge branch 'master' into add-trustlines-index
Shaptic Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions services/horizon/internal/db2/schema/bindata.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions ...ces/horizon/internal/db2/schema/migrations/61_trust_lines_by_account_type_code_issuer.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
-- +migrate Up

CREATE INDEX "trust_lines_by_type_code_issuer_account" ON trust_lines USING btree (asset_type, asset_code, asset_issuer, account_id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartekn, any thoughts on the duration this may take to complete on a full db(from pubnet genesis)? this would get applied to staging db which has that volume as part of release testing steps, could observe then?

DROP INDEX "trust_lines_by_type_code_issuer";

-- +migrate Down

DROP INDEX "trust_lines_by_type_code_issuer_account";
CREATE INDEX "trust_lines_by_type_code_issuer" ON trust_lines USING btree (asset_type, asset_code, asset_issuer);