Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Bump Go to 1.18.6 and 1.19.1 #4577

Merged
merged 3 commits into from
Sep 6, 2022
Merged

all: Bump Go to 1.18.6 and 1.19.1 #4577

merged 3 commits into from
Sep 6, 2022

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Sep 6, 2022

@bartekn bartekn requested review from leighmcculloch and a team September 6, 2022 17:35
paulbellamy
paulbellamy approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@paulbellamy paulbellamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but there's also a docker image Dockerfile.dev which is on golang:1.18. Would be good to update that as well so they stay in sync.

@bartekn
Copy link
Contributor Author

bartekn commented Sep 6, 2022

@paulbellamy done in 4f4faaf.

@bartekn bartekn merged commit 962edb1 into stellar:master Sep 6, 2022
@bartekn bartekn deleted the bump-golang-1.19.1 branch September 6, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

@paulbellamy paulbellamy paulbellamy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartekn @paulbellamy @leighmcculloch