Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add history_assets to lookup tables reap #4565

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Aug 31, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Adds the last remaining table: history_assets to lookup table reaper.

Close #4396.

Why

In #4518 the code responsible for reaping lookup tables was added but was missing one table: history_assets due to lack of proper indexes. This commit should remove all remaining data in lookup tables.

Known limitations

[TODO or N/A]

@bartekn bartekn requested a review from a team September 1, 2022 14:45
@bartekn bartekn marked this pull request as ready for review September 1, 2022 14:45
@bartekn bartekn merged commit 0f5afa2 into stellar:master Sep 6, 2022
@bartekn bartekn deleted the reap-assets branch September 6, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

horizon: history_claimable_balances is not cleared out by the reaper.
2 participants