Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --console flag for captive core 19.3.0 #4487

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

paulbellamy
Copy link
Contributor

@paulbellamy paulbellamy commented Jul 28, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Add --console flag for captive core 19.3.0

Why

So that logs still show up intermingled with the horizon log output, after the core 19.3.0 breaking change.

Known limitations

  • Core logs will no longer show up in their own separate place. e.g. var/lib/stellar.

  • Will break this version of horizon with core < 19.3.0

  • depends on bump core to latest 19.3.0 #4485

@paulbellamy paulbellamy requested a review from a team July 28, 2022 09:51
Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please update CHANGELOG in breaking changes section.

@paulbellamy paulbellamy force-pushed the core-19-3-0-console branch from c7f791d to 0310bcb Compare July 28, 2022 14:11
@paulbellamy paulbellamy merged commit 91d56a6 into release-horizon-v2.19.0 Jul 28, 2022
@paulbellamy paulbellamy deleted the core-19-3-0-console branch July 28, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants