Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

historyarchive: Add User-Agent header to history archive HTTP requests #4463

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jul 18, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Add UserAgent to historyarchive.ConnectOptions. The value will be propagated to User-Agent header send along http requests to history achive.

Why

This will allow better tracking of clients using history achives.

Known limitations

[TODO or N/A]

@bartekn bartekn requested a review from a team July 18, 2022 14:48
@bartekn bartekn marked this pull request as ready for review July 18, 2022 14:48
@bartekn bartekn merged commit 52a258d into stellar:master Jul 18, 2022
@bartekn bartekn deleted the historyarchive-useragent branch July 18, 2022 15:13
sreuland pushed a commit to sreuland/go that referenced this pull request Aug 7, 2022
stellar#4463)

Add `UserAgent` to `historyarchive.ConnectOptions`. The value will be propagated
to `User-Agent` header send along http requests to history achive. This will
allow better tracking of clients using history achives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants