exp/lighthorizon/index: Better errors, comments, small looping refactor. #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
force-pushed
the
lighthorizon_fixups
branch
2 times, most recently
from
2001768 to
e913102
Compare
Shaptic
force-pushed
the
lighthorizon_fixups
branch
from
e913102 to
1ac9e2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Besides more verbosity on error messages and better comments, I refactored the job loops to build the URLs once rather than whenever they're needed.
Why
This is faster (less string building), cleaner (less code), and safer (range-based rather than index-based loops).