Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp/lighthorizon: Add thread-safe support for reading account list from FileBackend. #4422

Merged
merged 15 commits into from
Jun 9, 2022
Merged

exp/lighthorizon: Add thread-safe support for reading account list from FileBackend. #4422

merged 15 commits into from
Jun 9, 2022

Commits on Jun 3, 2022

  1. Append over Write to deal w/ parallel writes: 

    According to S/O, parallel writes are thread-safe despite it not
being an explicit guarantee. This might be OS-specific, though?
Cross that bridge if we ever get there...
    @Shaptic
    Shaptic committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    c08fcad View commit details
    Browse the repository at this point in the history

  2. Add ability to read account list from file backend

    @Shaptic
    Shaptic committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    895a775 View commit details
    Browse the repository at this point in the history

  3. Use XDR for accounts in the "list" file

    @Shaptic
    Shaptic committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    db65892 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Use buffered reads w/ clean binary boundaries

    @Shaptic
    Shaptic committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    b4d7f48 View commit details
    Browse the repository at this point in the history

  2. Make returned account list unique

    @Shaptic
    Shaptic committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    06df7c1 View commit details
    Browse the repository at this point in the history

  3. Add test for account list on file backend

    @Shaptic
    Shaptic committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    3a749c0 View commit details
    Browse the repository at this point in the history

  4. Use built-in buffered reader + peeks to check EOFs

    @Shaptic
    Shaptic committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    6a1de69 View commit details
    Browse the repository at this point in the history

  5. Ignore non-EOFs

    @Shaptic
    Shaptic committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    478f925 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'lighthorizon' into lighthorizon_file-backend

    @Shaptic
    Shaptic committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    78181a0 View commit details
    Browse the repository at this point in the history

  7. Do a set union w/ existing accounts on a flush

    @Shaptic
    Shaptic committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    34b9ba2 View commit details
    Browse the repository at this point in the history

  8. Revert "Do a set union w/ existing accounts on a flush" 

    This reverts commit 34b9ba2.
    @Shaptic
    Shaptic committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    a59b4c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Okay yeah I think I just confused myself

    @Shaptic
    Shaptic committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    d821995 View commit details
    Browse the repository at this point in the history

  2. Use a constant

    @Shaptic
    Shaptic committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    35dc3b5 View commit details
    Browse the repository at this point in the history

  3. Fix error handling, off-by-one

    @Shaptic
    Shaptic committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    5eb47bd View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Combine building unique list while reading 🧠

    @Shaptic
    Shaptic committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    91468ec View commit details
    Browse the repository at this point in the history