Add integration test for extra signers using tx preconditions #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
reviewed
Apr 5, 2022
services/horizon/internal/integration/transaction_preconditions_test.go
Outdated
Show resolved
Hide resolved
Shaptic
reviewed
Apr 5, 2022
| // has also signed this transaction. | ||
| txParams.Preconditions.ExtraSigners = []string{addtlAccounts[0].GetAccountID()} | ||
| _, err = itest.SubmitMultiSigTransaction([]*keypair.Full{master, addtlSigners[0]}, txParams) | ||
| tt.NoError(err) |
There was a problem hiding this comment.
We should also make sure that retrieving the tx by ID shows the extra signers in the response, otherwise we aren't really testing Horizon at all besides txsub
There was a problem hiding this comment.
great suggestion, I added round trip asserts on the precond values in each of the test cases, thanks!
7 tasks
sreuland
changed the title
…bmitted tx per pr feedback
|
I just saw that the verify-range test is failing, I tried to rerun it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new integration test case for using the
Precondtions.ExtraSignersparameter with a standard AccountID as the additional signer.