Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txnbuild: add ClearSignatures functions to Transaction and FeeBumpTransaction #4173

Merged
merged 2 commits into from
Jan 11, 2022
Merged

txnbuild: add ClearSignatures functions to Transaction and FeeBumpTransaction #4173

merged 2 commits into from
Jan 11, 2022

Conversation

leighmcculloch
Copy link
Member

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Add ClearSignatures functions to Transaction and FeeBumpTransaction.

Why

Transaction and FeeBumpTransaction have functions for adding signatures, but not for clearing them to get back the original transaction without signatures attached. Without these functions the only way to remove signatures is to get the envelope and fiddle with the internals of the envelope, which seems not ideal. I need these functions for some code I'm writing using the Go SDK.

Known limitations

N/A

Copy link
Contributor

@nikhilsaraf nikhilsaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leighmcculloch leighmcculloch merged commit 0582e14 into stellar:master Jan 11, 2022
@leighmcculloch leighmcculloch deleted the txbuild-clearsignatures branch January 11, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants