all: run builds and tests with go1.18rc1 #4143
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,13 @@ | ||
| #! /bin/bash | ||
| set -e | ||
|
|
||
| gover=$(go version | { read _ _ gover _; printf $gover; }) | ||
|
|
||
| version='2020.1.4' | ||
| if [[ "$gover" = "go1.18"* ]]; then | ||
| version='d5c28addcbbbafca0b9a0f9ad8957912e9371015' | ||
| fi | ||
|
|
||
| staticcheck='go run honnef.co/go/tools/cmd/staticcheck@'"$version" | ||
|
|
||
| printf "Running staticcheck $version...\n" | ||
|
|
@@ -10,6 +16,10 @@ ls -d */ \ | |
| | egrep -v '^vendor|^docs' \ | ||
| | xargs -I {} $staticcheck -tests=false -checks="all,-ST1003,-SA1019,-ST1005,-ST1000,-ST1016,-S1039,-ST1021,-ST1020,-ST1019,-SA4022" ./{}... | ||
|
|
||
| # Whole program unused checks were removed from staticcheck in newer versions, | ||
| # so this check is being sunset and will be removed once Go 1.18 is released and | ||
| # a proper release of staticcheck is released that supports it. | ||
| if [ "$version" = "2020.1.4" ]; then | ||
| # Check horizon for unused exported symbols (relying on the fact that it should be self-contained) | ||
| $staticcheck -unused.whole-program -checks='U*' ./services/horizon/... | ||
| fi | ||
|
Comment on lines
+19
to
+25
There was a problem hiding this comment. FYI @stellar/horizon-committers. We'll be losing this check in the very near future because it was removed from staticcheck sometime ago. When Go 1.18 is released we'll upgrade our version of staticcheck and that version won't have the whole program unused check anymore. See dominikh/go-tools@5cfc85b. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity do you know why
1.16.7isn't included in this check job but is in the build and test jobs below? wondering if it's something we can remove below as well to speed up the workflow time (or should have here as well)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We support the last two versions of Go, but checks can change from one version to the next in subtle ways and there's little value in running the checks twice. What's more important is running tests and building against the previous version to be sure that we aren't using an API that isn't supported in the previous version, or to detect subtle API changes. Subtle API changes are so rare in Go that we probably will never see a error.