services/horizon: fix reingest duplicate errors on same ledger range #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreuland
force-pushed
the
4110_reingest_liquidity_pool_dup_error
branch
from
33d9dae
to
6572c6a
Compare
tamirms
approved these changes
Dec 2, 2021
|
@sreuland can you rebase on top of release-horizon-v2.12.0 and discard the commits which are not relevant? |
…te issue on liquidity pool tables(stellar#4114)
sreuland
force-pushed
the
4110_reingest_liquidity_pool_dup_error
branch
from
56e23bd
to
6e88a58
Compare
sreuland
commented
Dec 2, 2021
| tt.NoError(horizoncmd.RootCmd.Execute()) | ||
| tt.NoError(horizoncmd.RootCmd.Execute(), "Repeat the same reingest range against db, should not have errors.") |
There was a problem hiding this comment.
this is the crux of change, verifies repeated ingest works over same range on same db.
@tamirms , I rebased to the release branch and squashed, should be finished in CI soon, thanks! |
|
great, thanks! I will merge |
sreuland
added a commit
to sreuland/go
that referenced
this pull request
Dec 2, 2021
…te issue on liquidity pool tables(stellar#4114)
7 tasks
sreuland
added a commit
to sreuland/go
that referenced
this pull request
Aug 7, 2022
…te issue on liquidity pool tables(stellar#4114)
sreuland
added a commit
to sreuland/go
that referenced
this pull request
Aug 7, 2022
…te issue on liquidity pool tables(stellar#4114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
include liquidity pool tables in the ingest state machine's history operation purge for a given ledger range
Why
fix error during reingestion due to duplicate errors in liquidity pool table state
closes #4110
Known limitations
N/A